fix(extensions): ensure __init__.py in extension dir is present #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`gen_proto.sh` was deleting this file (or not recreating it) and if it isn't present, then it isn't possible to grab the extension yaml files in Python using `importlib.resources.files`. This restores the missing __init__.py file and also adds a `touch` to the `gen_proto.sh` script to make sure it sticks around.
|
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
EpsilonPrime
approved these changes
Aug 22, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gen_proto.shwas deleting this file (or not recreating it) and if it isn't present,then it isn't possible to grab the extension yaml files in Python using
importlib.resources.files.This restores the missing init.py file and also adds a
touchto thegen_proto.shscript to make sure it sticks around.